<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/9477">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">fix use after free in osmo_sccp_simple_server_add_clnt()<br><br>The variable as_name was freed before being passed to the<br>osmo_ss7_route_create() function. Free it later to avoid<br>a use-after-free crash with address sanitizer.<br><br>Found by running 'examples/m3ua_example aaa' with address<br>sanitizer enabled.<br><br>Change-Id: I9d724bc1d2aa8d6f8b6a67bdeafdb5f0f9136413<br>Related: OS#2666<br>---<br>M src/sccp_user.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/sccp_user.c b/src/sccp_user.c</span><br><span>index a6161c0..99ed96e 100644</span><br><span>--- a/src/sccp_user.c</span><br><span>+++ b/src/sccp_user.c</span><br><span>@@ -611,7 +611,6 @@</span><br><span>    as = osmo_ss7_as_find_or_create(ss7, as_name, prot);</span><br><span>         if (!as)</span><br><span>             goto out_strings;</span><br><span style="color: hsl(0, 100%, 40%);">-       talloc_free(as_name);</span><br><span> </span><br><span>    /* route only selected PC to the client */</span><br><span>   rt = osmo_ss7_route_create(ss7->rtable_system, pc, 0xffff, as_name);</span><br><span>@@ -624,6 +623,7 @@</span><br><span>        asp->cfg.is_server = true;</span><br><span>        osmo_ss7_as_add_asp(as, asp_name);</span><br><span>   talloc_free(asp_name);</span><br><span style="color: hsl(120, 100%, 40%);">+        talloc_free(as_name);</span><br><span>        osmo_ss7_asp_restart(asp);</span><br><span> </span><br><span>       return ss7->sccp;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9477">change 9477</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9477"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-sccp </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I9d724bc1d2aa8d6f8b6a67bdeafdb5f0f9136413 </div>
<div style="display:none"> Gerrit-Change-Number: 9477 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Stefan Sperling <ssperling@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>