<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/9468">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bsc: Fix f_establish_fully() for cases where we expect ASSIGN FAIL<br><br>When f_ass_patch_lcls() was recently introduced during LCLS support<br>patches, we broke any testcases that *expected* an ASSIGNMENT FAIL<br>by overwriting the ASSIGNMENT FAIL with an ASSIGNMENT COMPL.<br><br>This patch fixes f_ass_patch_lcls() to only patch 'assignmentComplete'<br>members, if this assignmentComplete is actually chosen.<br><br>This fixes BSC_Tests.TC_assignment_fr_a5_1_codec_missing<br><br>Change-Id: I64fbf4cc3178a91913143960475a0d3758779ced<br>---<br>M bsc/MSC_ConnectionHandler.ttcn<br>1 file changed, 6 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn</span><br><span>index 225e86b..0846762 100644</span><br><span>--- a/bsc/MSC_ConnectionHandler.ttcn</span><br><span>+++ b/bsc/MSC_ConnectionHandler.ttcn</span><br><span>@@ -742,10 +742,12 @@</span><br><span>     if (ispresent(g_pars.lcls.csc)) {</span><br><span>            ass_tpl.pdu.bssmap.assignmentRequest.lCLS_ConnectionStatusControl := ts_BSSMAP_IE_LclsCsc(g_pars.lcls.csc);</span><br><span>  }</span><br><span style="color: hsl(0, 100%, 40%);">-       if (ispresent(g_pars.lcls.exp_sts)) {</span><br><span style="color: hsl(0, 100%, 40%);">-           ass_cpl.pdu.bssmap.assignmentComplete.lCLS_BSS_Status := tr_BSSMAP_IE_LclsSts(g_pars.lcls.exp_sts);</span><br><span style="color: hsl(0, 100%, 40%);">-     } else {</span><br><span style="color: hsl(0, 100%, 40%);">-                ass_cpl.pdu.bssmap.assignmentComplete.lCLS_BSS_Status := omit;</span><br><span style="color: hsl(120, 100%, 40%);">+        if (ischosen(ass_cpl.pdu.bssmap.assignmentComplete)) {</span><br><span style="color: hsl(120, 100%, 40%);">+                if (ispresent(g_pars.lcls.exp_sts)) {</span><br><span style="color: hsl(120, 100%, 40%);">+                 ass_cpl.pdu.bssmap.assignmentComplete.lCLS_BSS_Status := tr_BSSMAP_IE_LclsSts(g_pars.lcls.exp_sts);</span><br><span style="color: hsl(120, 100%, 40%);">+           } else {</span><br><span style="color: hsl(120, 100%, 40%);">+                      ass_cpl.pdu.bssmap.assignmentComplete.lCLS_BSS_Status := omit;</span><br><span style="color: hsl(120, 100%, 40%);">+                }</span><br><span>    }</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9468">change 9468</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9468"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I64fbf4cc3178a91913143960475a0d3758779ced </div>
<div style="display:none"> Gerrit-Change-Number: 9468 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>