<p>daniel <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/9452">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Remove unused last_value handling code<br><br>Change-Id: I14cc5883af8ae73bc462ed714ef38c8ee1444cc6<br>---<br>M osysmon_ctrl.c<br>1 file changed, 1 insertion(+), 16 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/osysmon_ctrl.c b/osysmon_ctrl.c</span><br><span>index b13b13b..15521aa 100644</span><br><span>--- a/osysmon_ctrl.c</span><br><span>+++ b/osysmon_ctrl.c</span><br><span>@@ -63,8 +63,6 @@</span><br><span>             /* display name, if any */</span><br><span>           const char *display_name;</span><br><span>    } cfg;</span><br><span style="color: hsl(0, 100%, 40%);">-  /* most recent value we received for this */</span><br><span style="color: hsl(0, 100%, 40%);">-    char *last_value;</span><br><span> };</span><br><span> </span><br><span> static struct ctrl_client *ctrl_client_find(struct osysmon_state *os, const char *name)</span><br><span>@@ -275,27 +273,14 @@</span><br><span>               cc->sch = simple_ctrl_open(cc, cc->cfg.remote_host, cc->cfg.remote_port, 1000);</span><br><span>     /* abort, if that failed */</span><br><span>  if (!cc->sch) {</span><br><span style="color: hsl(0, 100%, 40%);">-              llist_for_each_entry(ccgv, &cc->get_vars, list) {</span><br><span style="color: hsl(0, 100%, 40%);">-                        if (ccgv->last_value) {</span><br><span style="color: hsl(0, 100%, 40%);">-                              talloc_free(ccgv->last_value);</span><br><span style="color: hsl(0, 100%, 40%);">-                               ccgv->last_value = talloc_strdup(ccgv, "<UNKNOWN>");</span><br><span style="color: hsl(0, 100%, 40%);">-                 }</span><br><span style="color: hsl(0, 100%, 40%);">-               }</span><br><span>            return -1;</span><br><span>   }</span><br><span> </span><br><span>        llist_for_each_entry(ccgv, &cc->get_vars, list) {</span><br><span>             char *value = simple_ctrl_get(cc->sch, ccgv->cfg.name);</span><br><span style="color: hsl(0, 100%, 40%);">-#if 0</span><br><span style="color: hsl(0, 100%, 40%);">-              if (ccgv->last_value) {</span><br><span style="color: hsl(0, 100%, 40%);">-                      talloc_free(ccgv->last_value);</span><br><span style="color: hsl(0, 100%, 40%);">-                       ccgv->last_value = NULL;</span><br><span style="color: hsl(0, 100%, 40%);">-             }</span><br><span style="color: hsl(0, 100%, 40%);">-               ccgv->last_value = value;</span><br><span style="color: hsl(0, 100%, 40%);">-#else</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>          value_node_add(vn_clnt, vn_clnt, ccgv->cfg.name, value);</span><br><span>          free(value); /* no talloc, this is from sscanf() */</span><br><span style="color: hsl(0, 100%, 40%);">-#endif</span><br><span>    }</span><br><span>    return 0;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9452">change 9452</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9452"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sysmon </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I14cc5883af8ae73bc462ed714ef38c8ee1444cc6 </div>
<div style="display:none"> Gerrit-Change-Number: 9452 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>