<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/9463">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">fix infinite recursion with routing by global title<br><br>We don't implement routing by global title address.<br>When processing an SCCP message which is routed by global title,<br>don't recurs indefinitely until the stack is exhausted.<br>Instead, return an error with cause SUBSYSTEM_FAILURE, which we<br>also do in other routing failure cases.<br><br>Change-Id: I24621e77ffc979bc337775f9c6a4ad9a9068625a<br>Related: OS#2666<br>---<br>M src/sccp_scrc.c<br>1 file changed, 7 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/sccp_scrc.c b/src/sccp_scrc.c</span><br><span>index dca5645..cd01774 100644</span><br><span>--- a/src/sccp_scrc.c</span><br><span>+++ b/src/sccp_scrc.c</span><br><span>@@ -279,8 +279,15 @@</span><br><span>      translated.ri != OSMO_SCCP_RI_SSN_IP) {</span><br><span>          /* TODO: GT Routing */</span><br><span>               LOGP(DLSCCP, LOGL_NOTICE, "GT Routing not implemented yet\n");</span><br><span style="color: hsl(120, 100%, 40%);">+#if 1</span><br><span style="color: hsl(120, 100%, 40%);">+               /* Prevent endless recursion, see OS#2666. */</span><br><span style="color: hsl(120, 100%, 40%);">+         sccp_sclc_rx_scrc_rout_fail(inst, xua,</span><br><span style="color: hsl(120, 100%, 40%);">+                        SCCP_RETURN_CAUSE_SUBSYSTEM_FAILURE);</span><br><span style="color: hsl(120, 100%, 40%);">+         return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+#else</span><br><span>             /* Node 7 (Sheet 5) */</span><br><span>               return scrc_node_7(inst, xua, called);</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span>       }</span><br><span> </span><br><span>        /* Check DPC resultant from GT translation */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9463">change 9463</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9463"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-sccp </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I24621e77ffc979bc337775f9c6a4ad9a9068625a </div>
<div style="display:none"> Gerrit-Change-Number: 9463 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Stefan Sperling <ssperling@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>