<p>Holger Freyther has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/9418">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mobile/sms: Simplify the string format routines<br><br>It seems the original code didn't allocate \0 for the string. Just use<br>talloc_asprintf and get a new string...<br><br>Change-Id: I8ffb50b04d2d6196caf0231711f3467abc8c5ea5<br>---<br>M src/host/layer23/src/mobile/gsm411_sms.c<br>1 file changed, 1 insertion(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/18/9418/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/host/layer23/src/mobile/gsm411_sms.c b/src/host/layer23/src/mobile/gsm411_sms.c</span><br><span>index 3eca48a..fe13ba1 100644</span><br><span>--- a/src/host/layer23/src/mobile/gsm411_sms.c</span><br><span>+++ b/src/host/layer23/src/mobile/gsm411_sms.c</span><br><span>@@ -182,7 +182,6 @@</span><br><span>     struct gsm_sms *gsms)</span><br><span> {</span><br><span>   const char osmocomsms[] = ".osmocom/bb/sms.txt";</span><br><span style="color: hsl(0, 100%, 40%);">-      int len;</span><br><span>     const char *home;</span><br><span>    char *sms_file;</span><br><span>      char vty_text[sizeof(gsms->text)], *p;</span><br><span>@@ -206,11 +205,9 @@</span><br><span>                     "your home directory.\n", osmocomsms);</span><br><span>             return GSM411_RP_CAUSE_MT_MEM_EXCEEDED;</span><br><span>      }</span><br><span style="color: hsl(0, 100%, 40%);">-       len = strlen(home) + 1 + sizeof(osmocomsms);</span><br><span style="color: hsl(0, 100%, 40%);">-    sms_file = talloc_size(l23_ctx, len);</span><br><span style="color: hsl(120, 100%, 40%);">+ sms_file = talloc_asprintf(l23_ctx, "%s/%s", home, osmocomsms);</span><br><span>    if (!sms_file)</span><br><span>               goto fail;</span><br><span style="color: hsl(0, 100%, 40%);">-      snprintf(sms_file, len, "%s/%s", home, osmocomsms);</span><br><span> </span><br><span>    fp = fopen(sms_file, "a");</span><br><span>         if (!fp) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9418">change 9418</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9418"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I8ffb50b04d2d6196caf0231711f3467abc8c5ea5 </div>
<div style="display:none"> Gerrit-Change-Number: 9418 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Holger Freyther <holger@freyther.de> </div>