<p>Holger Freyther has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/9417">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mobile/sms: Fix memory leak in case the storage can not be opened<br><br>Before jumping to the failure handling code free the sms_file.<br><br>Change-Id: Ifce2bc130fe3a5bd49ad457ee61002952dd496ba<br>---<br>M src/host/layer23/src/mobile/gsm411_sms.c<br>1 file changed, 3 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/17/9417/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/host/layer23/src/mobile/gsm411_sms.c b/src/host/layer23/src/mobile/gsm411_sms.c</span><br><span>index 9090697..3eca48a 100644</span><br><span>--- a/src/host/layer23/src/mobile/gsm411_sms.c</span><br><span>+++ b/src/host/layer23/src/mobile/gsm411_sms.c</span><br><span>@@ -213,8 +213,10 @@</span><br><span>       snprintf(sms_file, len, "%s/%s", home, osmocomsms);</span><br><span> </span><br><span>    fp = fopen(sms_file, "a");</span><br><span style="color: hsl(0, 100%, 40%);">-    if (!fp)</span><br><span style="color: hsl(120, 100%, 40%);">+      if (!fp) {</span><br><span style="color: hsl(120, 100%, 40%);">+            talloc_free(sms_file);</span><br><span>               goto fail;</span><br><span style="color: hsl(120, 100%, 40%);">+    }</span><br><span>    fprintf(fp, "[SMS from %s]\n%s\n", gsms->address, gsms->text);</span><br><span>       fclose(fp);</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9417">change 9417</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9417"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ifce2bc130fe3a5bd49ad457ee61002952dd496ba </div>
<div style="display:none"> Gerrit-Change-Number: 9417 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Holger Freyther <holger@freyther.de> </div>