<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://gerrit.osmocom.org/9417">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/9417/1/src/host/layer23/src/mobile/gsm411_sms.c">File src/host/layer23/src/mobile/gsm411_sms.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/9417/1/src/host/layer23/src/mobile/gsm411_sms.c@213">Patch Set #1, Line 213:</a> <code style="font-family:monospace,monospace">    snprintf(sms_file, len, "%s/%s", home, osmocomsms);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Hmm, we also compose a similar path in main.c.<br>Probably, it makes sense to compose this path<br>once there, and store somewhere in ms->settings...</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/9417">change 9417</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9417"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ifce2bc130fe3a5bd49ad457ee61002952dd496ba </div>
<div style="display:none"> Gerrit-Change-Number: 9417 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Holger Freyther <holger@freyther.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Sat, 02 Jun 2018 11:15:35 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>