<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/7631">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsm0480: fix: don't overwrite the data of RELEASE_COMPLETE<br><br>According to the 3GPP TS 04.80, table 2.5 'Release complete', a<br>RELEASE_COMPLETE message may containg optional FACILITY element.<br><br>Meanwhile, the 0xff byte is used to indicate that there is no<br>decoded message (legacy field). Let's avoid overwriting of<br>a decoded message.<br><br>Change-Id: I0c85292222749a48ca0c4b2e93f4fa2d61468c18<br>---<br>M src/gsm/gsm0480.c<br>1 file changed, 6 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gsm/gsm0480.c b/src/gsm/gsm0480.c</span><br><span>index 636f267..5c73e5b 100644</span><br><span>--- a/src/gsm/gsm0480.c</span><br><span>+++ b/src/gsm/gsm0480.c</span><br><span>@@ -296,11 +296,15 @@</span><br><span>        case GSM0480_MTYPE_RELEASE_COMPLETE:</span><br><span>                 LOGP(0, LOGL_DEBUG, "SS Release Complete\n");</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+           /**</span><br><span style="color: hsl(120, 100%, 40%);">+            * Indicates that there is no decoded message.</span><br><span style="color: hsl(120, 100%, 40%);">+                 * To be overwriten by the message otherwise.</span><br><span style="color: hsl(120, 100%, 40%);">+          */</span><br><span style="color: hsl(120, 100%, 40%);">+           req->ussd_text[0] = 0xFF;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>               /* Parse optional Cause and/or Facility data */</span><br><span>              if (len >= 2)</span><br><span>                     rc &= parse_ss_info_elements(&hdr->data[0], len, req);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-               req->ussd_text[0] = 0xFF;</span><br><span>                 break;</span><br><span>       case GSM0480_MTYPE_REGISTER:</span><br><span>                 rc &= parse_ss_info_elements(&hdr->data[0], len, req);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/7631">change 7631</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/7631"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I0c85292222749a48ca0c4b2e93f4fa2d61468c18 </div>
<div style="display:none"> Gerrit-Change-Number: 7631 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>