<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/9232">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">BSC_Tests: fix TC_ciph_mode_a5_{0,1,3}<br><br>The helper function f_tc_ciph_mode_a5(), thich performs all of the<br>three tests currently disables the ASSIGNMENT COMMAND since due to<br>a bug in OsmoBSC a MODE MODIFY would be attempted by the BSC,<br>causing the testcase to fail.<br><br>The problem in OsmoBSC is now fixed and the ASSIGNMENT COMMAND can<br>be re-enabled again for this test. However, the test function<br>includes and expects an AoIP transport layer address, which is<br>not included for signalling assignments.<br><br>- Make sure no AoIP transport identifier is included in ths<br>  ASSIGNMENT COMMAND<br><br>- Do not expect an AoIP transport identifier in the<br>  ASSIGNMENT COMPLETE from the BSC<br><br>- Re-Enable the generation of the ASSIGNMENT COMMAND<br><br>Change-Id: Ib39d7dd2d1b3665570d7b287e431d10111316437<br>Closes: OS#2936<br>---<br>M bsc/BSC_Tests.ttcn<br>1 file changed, 5 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn</span><br><span>index 58f2704..0da0a59 100644</span><br><span>--- a/bsc/BSC_Tests.ttcn</span><br><span>+++ b/bsc/BSC_Tests.ttcn</span><br><span>@@ -1473,10 +1473,12 @@</span><br><span>   var template PDU_BSSAP exp_compl := f_gen_exp_compl();</span><br><span>       var PDU_BSSAP ass_cmd := f_gen_ass_req();</span><br><span>    ass_cmd.pdu.bssmap.assignmentRequest.channelType := valueof(ts_BSSMAP_IE_ChannelTypeSIGNAL);</span><br><span style="color: hsl(120, 100%, 40%);">+  ass_cmd.pdu.bssmap.assignmentRequest.circuitIdentityCode := omit;</span><br><span style="color: hsl(120, 100%, 40%);">+     ass_cmd.pdu.bssmap.assignmentRequest.aoIPTransportLayer := omit;</span><br><span style="color: hsl(120, 100%, 40%);">+      exp_compl.pdu.bssmap.assignmentComplete.circuitIdentityCode := omit;</span><br><span style="color: hsl(120, 100%, 40%);">+  exp_compl.pdu.bssmap.assignmentComplete.aoIPTransportLayer := omit;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- // Disable generation of ASSIGNMENT CMD, as OsmoBSC currently performs MODE MODFIY sign->sign (OS#2936)</span><br><span style="color: hsl(0, 100%, 40%);">-      //f_establish_fully(ass_cmd, exp_compl);</span><br><span style="color: hsl(0, 100%, 40%);">-        f_establish_fully(omit, exp_compl);</span><br><span style="color: hsl(120, 100%, 40%);">+   f_establish_fully(ass_cmd, exp_compl);</span><br><span> }</span><br><span> testcase TC_ciph_mode_a5_0() runs on test_CT {</span><br><span>        var MSC_ConnHdlr vc_conn;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9232">change 9232</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9232"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ib39d7dd2d1b3665570d7b287e431d10111316437 </div>
<div style="display:none"> Gerrit-Change-Number: 9232 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>