<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/9351">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">acc_ramp: Increase log level of some messages<br><br>Right now, it's impossible to see any ACC Ramping information unless RSL<br>category is set to DEBUG. Barring and Allowing Access Control Class is<br>an important event which should be printed in most cases.<br><br>Increase log levels of messages printed during some error conditions to<br>be handled as errors.<br><br>Backport of osmo-bsc.git commit<br>67f20bc356a4908bdb71b5dfc6a1932e6c1fac68.<br><br>Change-Id: Iec10c2be7aa5efeadd6b0706916678acc5461111<br>---<br>M openbsc/src/libbsc/acc_ramp.c<br>1 file changed, 4 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/openbsc/src/libbsc/acc_ramp.c b/openbsc/src/libbsc/acc_ramp.c</span><br><span>index c90d087..0c4dbac 100644</span><br><span>--- a/openbsc/src/libbsc/acc_ramp.c</span><br><span>+++ b/openbsc/src/libbsc/acc_ramp.c</span><br><span>@@ -46,7 +46,7 @@</span><br><span> {</span><br><span>   OSMO_ASSERT(acc >= 0 && acc <= 9);</span><br><span>     if (acc_ramp->barred_accs & (1 << acc))</span><br><span style="color: hsl(0, 100%, 40%);">-            LOGP(DRSL, LOGL_DEBUG, "(bts=%d) ACC RAMP: allowing Access Control Class %u\n", acc_ramp->bts->nr, acc);</span><br><span style="color: hsl(120, 100%, 40%);">+              LOGP(DRSL, LOGL_NOTICE, "(bts=%d) ACC RAMP: allowing Access Control Class %u\n", acc_ramp->bts->nr, acc);</span><br><span>    acc_ramp->barred_accs &= ~(1 << acc);</span><br><span> }</span><br><span> </span><br><span>@@ -54,7 +54,7 @@</span><br><span> {</span><br><span>         OSMO_ASSERT(acc >= 0 && acc <= 9);</span><br><span>     if ((acc_ramp->barred_accs & (1 << acc)) == 0)</span><br><span style="color: hsl(0, 100%, 40%);">-             LOGP(DRSL, LOGL_DEBUG, "(bts=%d) ACC RAMP: barring Access Control Class %u\n", acc_ramp->bts->nr, acc);</span><br><span style="color: hsl(120, 100%, 40%);">+               LOGP(DRSL, LOGL_NOTICE, "(bts=%d) ACC RAMP: barring Access Control Class %u\n", acc_ramp->bts->nr, acc);</span><br><span>     acc_ramp->barred_accs |= (1 << acc);</span><br><span> }</span><br><span> </span><br><span>@@ -210,7 +210,7 @@</span><br><span>                         break;</span><br><span>               case NM_STATE_NULL:</span><br><span>          default:</span><br><span style="color: hsl(0, 100%, 40%);">-                        LOGP(DRSL, LOGL_NOTICE, "(bts=%d) ACC RAMP: unrecognized administrative state '0x%x' "</span><br><span style="color: hsl(120, 100%, 40%);">+                      LOGP(DRSL, LOGL_ERROR, "(bts=%d) ACC RAMP: unrecognized administrative state '0x%x' "</span><br><span>                          "reported for TRX 0\n", acc_ramp->bts->nr, nsd->new_state->administrative);</span><br><span>                        break;</span><br><span>               }</span><br><span>@@ -249,7 +249,7 @@</span><br><span>                      break;</span><br><span>               case NM_OPSTATE_NULL:</span><br><span>                default:</span><br><span style="color: hsl(0, 100%, 40%);">-                        LOGP(DRSL, LOGL_NOTICE, "(bts=%d) ACC RAMP: unrecognized operational state '0x%x' "</span><br><span style="color: hsl(120, 100%, 40%);">+                 LOGP(DRSL, LOGL_ERROR, "(bts=%d) ACC RAMP: unrecognized operational state '0x%x' "</span><br><span>                              "reported for TRX 0\n", acc_ramp->bts->nr, nsd->new_state->administrative);</span><br><span>                       break;</span><br><span>               }</span><br><span>@@ -361,4 +361,3 @@</span><br><span> </span><br><span>  allow_all_accs(acc_ramp);</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9351">change 9351</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9351"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: openbsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Iec10c2be7aa5efeadd6b0706916678acc5461111 </div>
<div style="display:none"> Gerrit-Change-Number: 9351 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>