<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/8020">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
Harald Welte: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">make PCU tests send PS paging requests on BVCI zero<br><br>osmo-pcu discards PAGING-PS messages unless received on the<br>signalling BVCI 0. The BVCI value must be set to zero both<br>in the NS header and the BSSGP header. Create new ports between<br>the PCU_Test components which the TC_paging test case can use<br>to ensure that both layers send frames with BVCI value of zero.<br><br>This does not make PCU_Tests.tc_paging work yet, however the PS<br>paging request is now processed by osmo-pcu rather than discarded.<br><br>Change-Id: I0437123b04b7320a4f690f0646578c57abf6bc87<br>Related: OS#2404<br>---<br>M library/BSSGP_Emulation.ttcn<br>M pcu/PCU_Tests.ttcn<br>2 files changed, 11 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/BSSGP_Emulation.ttcn b/library/BSSGP_Emulation.ttcn</span><br><span>index c7766dc..321c344 100644</span><br><span>--- a/library/BSSGP_Emulation.ttcn</span><br><span>+++ b/library/BSSGP_Emulation.ttcn</span><br><span>@@ -80,6 +80,7 @@</span><br><span> </span><br><span> type component BSSGP_Client_CT {</span><br><span> port BSSGP_PT BSSGP;</span><br><span style="color: hsl(120, 100%, 40%);">+ port BSSGP_PT BSSGP_SIG;</span><br><span> port BSSGP_PROC_PT BSSGP_PROC;</span><br><span> };</span><br><span> </span><br><span>@@ -99,10 +100,11 @@</span><br><span> }</span><br><span> </span><br><span> type component BSSGP_CT {</span><br><span style="color: hsl(0, 100%, 40%);">- /* UDP port towards the bottom (IUT) */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* UDP ports towards the bottom (IUT) */</span><br><span> port NS_PT BSCP;</span><br><span> /* NS-User SAP towards the user */</span><br><span> port BSSGP_SP_PT BSSGP_SP;</span><br><span style="color: hsl(120, 100%, 40%);">+ port BSSGP_SP_PT BSSGP_SP_SIG;</span><br><span> port BSSGP_PROC_PT BSSGP_PROC;</span><br><span> </span><br><span> var BssgpConfig g_cfg;</span><br><span>@@ -534,6 +536,10 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ [] BSSGP_SP_SIG.receive(PDU_BSSGP:?)-> value bs_pdu sender vc_conn {</span><br><span style="color: hsl(120, 100%, 40%);">+ BSCP.send(f_BnsUdReq(bs_pdu, 0));</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* pass virtually any PDU from user to NS-UNITDATA PDU on network */</span><br><span> [] BSSGP_SP.receive(PDU_BSSGP:?) -> value bs_pdu sender vc_conn {</span><br><span> BSCP.send(f_BnsUdReq(bs_pdu, g_cfg.bvci));</span><br><span>diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn</span><br><span>index 12b63d6..6e36f68 100644</span><br><span>--- a/pcu/PCU_Tests.ttcn</span><br><span>+++ b/pcu/PCU_Tests.ttcn</span><br><span>@@ -60,6 +60,7 @@</span><br><span> bssgp_component := BSSGP_CT.create;</span><br><span> /* connect our BSSGP port to the BSSGP Emulation */</span><br><span> connect(self:BSSGP, bssgp_component:BSSGP_SP);</span><br><span style="color: hsl(120, 100%, 40%);">+ connect(self:BSSGP_SIG, bssgp_component:BSSGP_SP_SIG);</span><br><span> connect(self:BSSGP_PROC, bssgp_component:BSSGP_PROC);</span><br><span> /* connect lower-end of BSSGP with BSSGP_CODEC_PORT (maps to NS_PT*/</span><br><span> connect(bssgp_component:BSCP, ns_component:NS_SP);</span><br><span>@@ -200,8 +201,9 @@</span><br><span> g_mmctx.tlli := f_random_tlli();</span><br><span> f_init();</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- BSSGP.send(ts_BSSGP_PS_PAGING_IMSI(mp_gb_cfg.bvci, g_mmctx.imsi));</span><br><span style="color: hsl(0, 100%, 40%);">- BSSGP.send(ts_BSSGP_PS_PAGING_PTMSI(mp_gb_cfg.bvci, g_mmctx.imsi, tmsi));</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Send paging on signalling BVCI 0 since osmo-pcu does not support paging on PTP yet. */</span><br><span style="color: hsl(120, 100%, 40%);">+ BSSGP_SIG.send(ts_BSSGP_PS_PAGING_IMSI(0, g_mmctx.imsi));</span><br><span style="color: hsl(120, 100%, 40%);">+ BSSGP_SIG.send(ts_BSSGP_PS_PAGING_PTMSI(0, g_mmctx.imsi, tmsi));</span><br><span> </span><br><span> while (true) {</span><br><span> var BssgpDecoded bd;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/8020">change 8020</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/8020"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I0437123b04b7320a4f690f0646578c57abf6bc87 </div>
<div style="display:none"> Gerrit-Change-Number: 8020 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Stefan Sperling <ssperling@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: Stefan Sperling <ssperling@sysmocom.de> </div>