<p>Harald Welte has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/9322">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bsc: Don't create MSC-side MGCP connection in IPA/SCCPlite case<br><br>In IPA/SCCPlite, the MSC is handling MGCP to the BSC-MGW directly<br>and the BSC only takes care of the BTS-side MGCP connection.  We<br>achieve this by transitioning directly from WAIT_MDCX_BTS into ACTIVE<br>in this case.<br><br>Change-Id: I96179b4324b976bded36023a8ccbdc007b6b3e05<br>Related: OS#2544<br>---<br>M src/libbsc/bsc_subscr_conn_fsm.c<br>1 file changed, 19 insertions(+), 9 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/22/9322/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libbsc/bsc_subscr_conn_fsm.c b/src/libbsc/bsc_subscr_conn_fsm.c</span><br><span>index 73e9224..ed3c8f3 100644</span><br><span>--- a/src/libbsc/bsc_subscr_conn_fsm.c</span><br><span>+++ b/src/libbsc/bsc_subscr_conn_fsm.c</span><br><span>@@ -681,16 +681,26 @@</span><br><span>           * BTS connection. */</span><br><span>                osmo_strlcpy(conn_peer.endpoint, conn->user_plane.mgw_endpoint, sizeof(conn_peer.endpoint));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-             /* (Pre)Change state and create the connection */</span><br><span style="color: hsl(0, 100%, 40%);">-               osmo_fsm_inst_state_chg(fi, ST_WAIT_CRCX_MSC, MGCP_MGW_TIMEOUT, MGCP_MGW_TIMEOUT_TIMER_NR);</span><br><span style="color: hsl(0, 100%, 40%);">-             conn->user_plane.fi_msc =</span><br><span style="color: hsl(0, 100%, 40%);">-                mgcp_conn_create(conn->network->mgw.client, fi, GSCON_EV_MGW_FAIL_MSC, GSCON_EV_MGW_CRCX_RESP_MSC,</span><br><span style="color: hsl(0, 100%, 40%);">-                                 &conn_peer);</span><br><span style="color: hsl(0, 100%, 40%);">-           if (!conn->user_plane.fi_msc) {</span><br><span style="color: hsl(0, 100%, 40%);">-                      resp = gsm0808_create_assignment_failure(GSM0808_CAUSE_EQUIPMENT_FAILURE, NULL);</span><br><span style="color: hsl(0, 100%, 40%);">-                        sigtran_send(conn, resp, fi);</span><br><span style="color: hsl(120, 100%, 40%);">+         switch (conn->sccp.msc->a.asp_proto) {</span><br><span style="color: hsl(120, 100%, 40%);">+          case OSMO_SS7_ASP_PROT_IPA:</span><br><span style="color: hsl(120, 100%, 40%);">+                   /* Send assignment complete message to the MSC */</span><br><span style="color: hsl(120, 100%, 40%);">+                     send_ass_compl(conn->lchan, fi, true);</span><br><span>                    osmo_fsm_inst_state_chg(fi, ST_ACTIVE, 0, 0);</span><br><span style="color: hsl(0, 100%, 40%);">-                   return;</span><br><span style="color: hsl(120, 100%, 40%);">+                       break;</span><br><span style="color: hsl(120, 100%, 40%);">+                default:</span><br><span style="color: hsl(120, 100%, 40%);">+                      /* (Pre)Change state and create the connection */</span><br><span style="color: hsl(120, 100%, 40%);">+                     osmo_fsm_inst_state_chg(fi, ST_WAIT_CRCX_MSC, MGCP_MGW_TIMEOUT,</span><br><span style="color: hsl(120, 100%, 40%);">+                                               MGCP_MGW_TIMEOUT_TIMER_NR);</span><br><span style="color: hsl(120, 100%, 40%);">+                   conn->user_plane.fi_msc = mgcp_conn_create(conn->network->mgw.client, fi,</span><br><span style="color: hsl(120, 100%, 40%);">+                                                              GSCON_EV_MGW_FAIL_MSC,</span><br><span style="color: hsl(120, 100%, 40%);">+                                                                GSCON_EV_MGW_CRCX_RESP_MSC, &conn_peer);</span><br><span style="color: hsl(120, 100%, 40%);">+                        if (!conn->user_plane.fi_msc) {</span><br><span style="color: hsl(120, 100%, 40%);">+                            resp = gsm0808_create_assignment_failure(GSM0808_CAUSE_EQUIPMENT_FAILURE, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+                              sigtran_send(conn, resp, fi);</span><br><span style="color: hsl(120, 100%, 40%);">+                         osmo_fsm_inst_state_chg(fi, ST_ACTIVE, 0, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+                         return;</span><br><span style="color: hsl(120, 100%, 40%);">+                       }</span><br><span style="color: hsl(120, 100%, 40%);">+                     break;</span><br><span>               }</span><br><span> </span><br><span>                break;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9322">change 9322</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9322"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I96179b4324b976bded36023a8ccbdc007b6b3e05 </div>
<div style="display:none"> Gerrit-Change-Number: 9322 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>