<p>Neels Hofmeyr has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/9281">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">assignment: signal assignment failure on chan act nack<br><br>When the BTS responds with a Chan Act NACK, i.e. the lchan could not be<br>activated, immediately signal Assignment Failure to the MSC (in<br>handle_chan_nack()).<br><br>In handle_chan_nack(), adjust log: instead of waiting for timeout, we now<br>signal Assignment Failure.<br><br>Cosmetic: in this file, the struct bsc_api* is typically named 'bsc', not<br>'api', so rename the arg.<br><br>Drop misleading logging from bsc_assign_fail(): instead of transmitting the<br>Assignment Failure message, it actually signals an FSM event. Leave logging of<br>that to the FSM logging.<br><br>Change-Id: Ib204b4a5272f9b7b60ca5f932cd8a4c857316270<br>---<br>M src/libbsc/bsc_api.c<br>M src/osmo-bsc/osmo_bsc_api.c<br>2 files changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/81/9281/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libbsc/bsc_api.c b/src/libbsc/bsc_api.c</span><br><span>index 8ae781e..043a5a7 100644</span><br><span>--- a/src/libbsc/bsc_api.c</span><br><span>+++ b/src/libbsc/bsc_api.c</span><br><span>@@ -825,14 +825,15 @@</span><br><span> }</span><br><span> </span><br><span> static void handle_chan_nack(struct gsm_subscriber_connection *conn,</span><br><span style="color: hsl(0, 100%, 40%);">-                             struct bsc_api *api, struct gsm_lchan *lchan)</span><br><span style="color: hsl(120, 100%, 40%);">+                         struct bsc_api *bsc, struct gsm_lchan *lchan)</span><br><span> {</span><br><span>      if (conn->secondary_lchan != lchan)</span><br><span>               return;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     LOGPLCHAN(lchan, DMSC, LOGL_ERROR, "Channel activation failed. Waiting for timeout now\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPLCHAN(lchan, DMSC, LOGL_ERROR, "Channel activation failed.\n");</span><br><span>        conn->secondary_lchan->conn = NULL;</span><br><span>    conn->secondary_lchan = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+      bsc->assign_fail(conn, GSM0808_CAUSE_RADIO_INTERFACE_FAILURE, NULL);</span><br><span> }</span><br><span> </span><br><span> static __attribute__((constructor)) void on_dso_load_bsc(void)</span><br><span>diff --git a/src/osmo-bsc/osmo_bsc_api.c b/src/osmo-bsc/osmo_bsc_api.c</span><br><span>index 8c16bde..e026b69 100644</span><br><span>--- a/src/osmo-bsc/osmo_bsc_api.c</span><br><span>+++ b/src/osmo-bsc/osmo_bsc_api.c</span><br><span>@@ -426,7 +426,6 @@</span><br><span> static void bsc_assign_fail(struct gsm_subscriber_connection *conn,</span><br><span>                         uint8_t cause, uint8_t *rr_cause)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-      LOGP(DMSC, LOGL_INFO, "Tx MSC ASSIGN FAIL\n");</span><br><span>     osmo_fsm_inst_dispatch(conn->fi, GSCON_EV_RR_ASS_FAIL, NULL);</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9281">change 9281</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9281"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ib204b4a5272f9b7b60ca5f932cd8a4c857316270 </div>
<div style="display:none"> Gerrit-Change-Number: 9281 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>