<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/9255">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Harald Welte: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_gmm: make functions relating to GMM Attach Request public<br><br>GMM Attach Request will be handled in it's own file and will<br>use those functions.<br><br>Change-Id: Ic90d77f7b0bacd2a8e2e409e82d676772d352749<br>---<br>M include/osmocom/sgsn/gprs_gmm.h<br>M src/gprs/gprs_gmm.c<br>2 files changed, 13 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/sgsn/gprs_gmm.h b/include/osmocom/sgsn/gprs_gmm.h</span><br><span>index 6324c5d..b89eff5 100644</span><br><span>--- a/include/osmocom/sgsn/gprs_gmm.h</span><br><span>+++ b/include/osmocom/sgsn/gprs_gmm.h</span><br><span>@@ -11,6 +11,9 @@</span><br><span> uint8_t cause, uint8_t pco_len, uint8_t *pco_v);</span><br><span> int gsm48_tx_gsm_act_pdp_acc(struct sgsn_pdp_ctx *pdp);</span><br><span> int gsm48_tx_gsm_deact_pdp_acc(struct sgsn_pdp_ctx *pdp);</span><br><span style="color: hsl(120, 100%, 40%);">+int gsm48_tx_gmm_auth_ciph_req(struct sgsn_mm_ctx *mm,</span><br><span style="color: hsl(120, 100%, 40%);">+ const struct osmo_auth_vector *vec,</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t key_seq, bool force_standby);</span><br><span> </span><br><span> int gsm0408_gprs_rcvmsg_gb(struct msgb *msg, struct gprs_llc_llme *llme,</span><br><span> bool drop_cipherable);</span><br><span>@@ -32,4 +35,9 @@</span><br><span> </span><br><span> int iu_rab_act_ps(uint8_t rab_id, struct sgsn_pdp_ctx *pdp);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+int gsm48_tx_gmm_id_req(struct sgsn_mm_ctx *mm, uint8_t id_type);</span><br><span style="color: hsl(120, 100%, 40%);">+int gsm48_tx_gmm_att_rej(struct sgsn_mm_ctx *mm,</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t gmm_cause);</span><br><span style="color: hsl(120, 100%, 40%);">+int gsm48_tx_gmm_att_ack(struct sgsn_mm_ctx *mm);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> #endif /* _GPRS_GMM_H */</span><br><span>diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c</span><br><span>index 93d64a4..df498c1 100644</span><br><span>--- a/src/gprs/gprs_gmm.c</span><br><span>+++ b/src/gprs/gprs_gmm.c</span><br><span>@@ -424,7 +424,7 @@</span><br><span> };</span><br><span> </span><br><span> /* Chapter 9.4.2: Attach accept */</span><br><span style="color: hsl(0, 100%, 40%);">-static int gsm48_tx_gmm_att_ack(struct sgsn_mm_ctx *mm)</span><br><span style="color: hsl(120, 100%, 40%);">+int gsm48_tx_gmm_att_ack(struct sgsn_mm_ctx *mm)</span><br><span> {</span><br><span> struct msgb *msg = gsm48_msgb_alloc_name("GSM 04.08 ATT ACK");</span><br><span> struct gsm48_hdr *gh;</span><br><span>@@ -503,7 +503,7 @@</span><br><span> gmm_copy_id(msg, old_msg);</span><br><span> return _tx_gmm_att_rej(msg, gmm_cause, NULL);</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">-static int gsm48_tx_gmm_att_rej(struct sgsn_mm_ctx *mm,</span><br><span style="color: hsl(120, 100%, 40%);">+int gsm48_tx_gmm_att_rej(struct sgsn_mm_ctx *mm,</span><br><span> uint8_t gmm_cause)</span><br><span> {</span><br><span> struct msgb *msg = gsm48_msgb_alloc_name("GSM 04.08 ATT REJ");</span><br><span>@@ -547,7 +547,7 @@</span><br><span> }</span><br><span> </span><br><span> /* Transmit Chapter 9.4.12 Identity Request */</span><br><span style="color: hsl(0, 100%, 40%);">-static int gsm48_tx_gmm_id_req(struct sgsn_mm_ctx *mm, uint8_t id_type)</span><br><span style="color: hsl(120, 100%, 40%);">+int gsm48_tx_gmm_id_req(struct sgsn_mm_ctx *mm, uint8_t id_type)</span><br><span> {</span><br><span> struct msgb *msg = gsm48_msgb_alloc_name("GSM 04.08 ID REQ");</span><br><span> struct gsm48_hdr *gh;</span><br><span>@@ -577,7 +577,7 @@</span><br><span> }</span><br><span> </span><br><span> /* 3GPP TS 24.008 Section 9.4.9: Authentication and Ciphering Request */</span><br><span style="color: hsl(0, 100%, 40%);">-static int gsm48_tx_gmm_auth_ciph_req(struct sgsn_mm_ctx *mm,</span><br><span style="color: hsl(120, 100%, 40%);">+int gsm48_tx_gmm_auth_ciph_req(struct sgsn_mm_ctx *mm,</span><br><span> const struct osmo_auth_vector *vec,</span><br><span> uint8_t key_seq, bool force_standby)</span><br><span> {</span><br><span>@@ -1533,7 +1533,7 @@</span><br><span> }</span><br><span> </span><br><span> /* Chapter 9.4.17: Routing area update reject */</span><br><span style="color: hsl(0, 100%, 40%);">-static int gsm48_tx_gmm_ra_upd_rej(struct msgb *old_msg, uint8_t cause)</span><br><span style="color: hsl(120, 100%, 40%);">+int gsm48_tx_gmm_ra_upd_rej(struct msgb *old_msg, uint8_t cause)</span><br><span> {</span><br><span> struct msgb *msg = gsm48_msgb_alloc_name("GSM 04.08 RA UPD REJ");</span><br><span> struct gsm48_hdr *gh;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9255">change 9255</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9255"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ic90d77f7b0bacd2a8e2e409e82d676772d352749 </div>
<div style="display:none"> Gerrit-Change-Number: 9255 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>