<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/9218">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">add counter for connection attempts from BTS with unknown unit id<br><br>Add a global counter to the BSC which shows the number of failed<br>connections attempts due to a unit_id mismatch between the BSC<br>and the BTS.<br><br>Change-Id: I58866aff36a1c8463bf84b4392a5124ffeaa32ea<br>Related: OS#3245<br>---<br>M include/osmocom/bsc/gsm_data.h<br>M src/libbsc/bts_ipaccess_nanobts.c<br>2 files changed, 4 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h</span><br><span>index 6365938..6f854d8 100644</span><br><span>--- a/include/osmocom/bsc/gsm_data.h</span><br><span>+++ b/include/osmocom/bsc/gsm_data.h</span><br><span>@@ -1128,6 +1128,7 @@</span><br><span>    BSC_CTR_PAGING_ATTEMPTED,</span><br><span>    BSC_CTR_PAGING_DETACHED,</span><br><span>     BSC_CTR_PAGING_RESPONDED,</span><br><span style="color: hsl(120, 100%, 40%);">+     BSC_CTR_UNKNOWN_UNIT_ID,</span><br><span> };</span><br><span> </span><br><span> static const struct rate_ctr_desc bsc_ctr_description[] = {</span><br><span>@@ -1140,6 +1141,8 @@</span><br><span>    [BSC_CTR_PAGING_ATTEMPTED] =            {"paging:attempted", "Paging attempts for a subscriber."},</span><br><span>       [BSC_CTR_PAGING_DETACHED] =             {"paging:detached", "Paging request send failures because no responsible BTS was found."},</span><br><span>       [BSC_CTR_PAGING_RESPONDED] =            {"paging:responded", "Paging attempts with successful response."},</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+      [BSC_CTR_UNKNOWN_UNIT_ID] =             {"abis:unknown_unit_id", "Connection attempts from unknown IPA CCM Unit ID."},</span><br><span> };</span><br><span> </span><br><span> </span><br><span>diff --git a/src/libbsc/bts_ipaccess_nanobts.c b/src/libbsc/bts_ipaccess_nanobts.c</span><br><span>index d5b3b21..823fd66 100644</span><br><span>--- a/src/libbsc/bts_ipaccess_nanobts.c</span><br><span>+++ b/src/libbsc/bts_ipaccess_nanobts.c</span><br><span>@@ -468,6 +468,7 @@</span><br><span>              LOGP(DLINP, LOGL_ERROR, "Unable to find BTS configuration for "</span><br><span>                    " %u/%u/%u, disconnecting\n", dev->site_id,</span><br><span>                     dev->bts_id, dev->trx_id);</span><br><span style="color: hsl(120, 100%, 40%);">+              rate_ctr_inc(&bsc_gsmnet->bsc_ctrs->ctr[BSC_CTR_UNKNOWN_UNIT_ID]);</span><br><span>                 return NULL;</span><br><span>         }</span><br><span>    DEBUGP(DLINP, "Identified BTS %u/%u/%u\n",</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9218">change 9218</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9218"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I58866aff36a1c8463bf84b4392a5124ffeaa32ea </div>
<div style="display:none"> Gerrit-Change-Number: 9218 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Stefan Sperling <ssperling@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Stefan Sperling <ssperling@sysmocom.de> </div>