<p>lynxis lazus has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/9245">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">L3_Templates: rename tr_GMM_DET_ACCEPT_MT -> tr_GMM_DET_ACCEPT_MO<br><br>The standard defines this messages, even it's send from the Network -> MS as MO,<br>because the procedure initiated by the MS.<br><br>Change-Id: I4b5e2d43c9754d34b3749bff43b7df7196b9bb9c<br>---<br>M library/L3_Templates.ttcn<br>M sgsn/SGSN_Tests.ttcn<br>2 files changed, 5 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/45/9245/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/L3_Templates.ttcn b/library/L3_Templates.ttcn</span><br><span>index 5acd2bf..b2bfb07 100644</span><br><span>--- a/library/L3_Templates.ttcn</span><br><span>+++ b/library/L3_Templates.ttcn</span><br><span>@@ -1843,7 +1843,7 @@</span><br><span>    }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-template PDU_L3_SGSN_MS tr_GMM_DET_ACCEPT_MT := {</span><br><span style="color: hsl(120, 100%, 40%);">+template PDU_L3_SGSN_MS tr_GMM_DET_ACCEPT_MO := {</span><br><span>       discriminator := '1000'B,</span><br><span>    tiOrSkip := {</span><br><span>                skipIndicator := '0000'B</span><br><span>@@ -1859,7 +1859,7 @@</span><br><span>     }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-template PDU_L3_SGSN_MS tr_GMM_DET_REQ_MT(template BIT3 dtt := ?, template boolean power_off := ?) := {</span><br><span style="color: hsl(120, 100%, 40%);">+template PDU_L3_SGSN_MS tr_GMM_DET_REQ_MO(template BIT3 dtt := ?, template boolean power_off := ?) := {</span><br><span>   discriminator := '1000'B,</span><br><span>    tiOrSkip := {</span><br><span>                skipIndicator := '0000'B</span><br><span>diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn</span><br><span>index e1d35c5..36a4700 100644</span><br><span>--- a/sgsn/SGSN_Tests.ttcn</span><br><span>+++ b/sgsn/SGSN_Tests.ttcn</span><br><span>@@ -784,7 +784,7 @@</span><br><span>  [not expect_purge] GSUP.receive(tr_GSUP_PURGE_MS_REQ(?)) {</span><br><span>           setverdict(fail, "Unexpected GSUP PURGE MS for unregistered TLLI");</span><br><span>                }</span><br><span style="color: hsl(0, 100%, 40%);">-       [power_off] BSSGP.receive(tr_BD_L3_MT(tr_GMM_DET_ACCEPT_MT)) -> value bd {</span><br><span style="color: hsl(120, 100%, 40%);">+ [power_off] BSSGP.receive(tr_BD_L3_MT(tr_GMM_DET_ACCEPT_MO)) -> value bd {</span><br><span>                g_pars.ra := omit;</span><br><span>           setverdict(fail, "Unexpected ATTACH ACCEPT in no-power-off DETACH");</span><br><span>               /* TODO: check if any PDP contexts are deactivated on network side? */</span><br><span>@@ -792,7 +792,7 @@</span><br><span>         [power_off] T.timeout {</span><br><span>              setverdict(pass);</span><br><span>            }</span><br><span style="color: hsl(0, 100%, 40%);">-       [not power_off] BSSGP.receive(tr_BD_L3_MT(tr_GMM_DET_ACCEPT_MT)) -> value bd {</span><br><span style="color: hsl(120, 100%, 40%);">+     [not power_off] BSSGP.receive(tr_BD_L3_MT(tr_GMM_DET_ACCEPT_MO)) -> value bd {</span><br><span>            g_pars.ra := omit;</span><br><span>           setverdict(pass);</span><br><span>            /* TODO: check if any PDP contexts are deactivated on network side? */</span><br><span>@@ -1130,7 +1130,7 @@</span><br><span>                                    apars.apn, apars.pco));</span><br><span>         alt {</span><br><span>        /* We might want toalso actually expect a PDPC CTX ACT REJ? */</span><br><span style="color: hsl(0, 100%, 40%);">-  [] BSSGP.receive(tr_BD_L3_MT(tr_GMM_DET_REQ_MT(?, ?))) {</span><br><span style="color: hsl(120, 100%, 40%);">+      [] BSSGP.receive(tr_BD_L3_MT(tr_GMM_DET_REQ_MO(?, ?))) {</span><br><span>             setverdict(pass);</span><br><span>            }</span><br><span>    [] GTP.receive(tr_GTPC_MsgType(?, createPDPContextRequest, ?)) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9245">change 9245</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9245"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I4b5e2d43c9754d34b3749bff43b7df7196b9bb9c </div>
<div style="display:none"> Gerrit-Change-Number: 9245 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>