<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://gerrit.osmocom.org/9214">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/9214/1/include/osmocom/bsc/bsc_nat.h">File include/osmocom/bsc/bsc_nat.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/9214/1/include/osmocom/bsc/bsc_nat.h@180">Patch Set #1, Line 180:</a> <code style="font-family:monospace,monospace">     bool bts_use_jibuf;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I would prefer something like a sub-structure </p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">struct {<br>   ....<br>} bts_jitter;</pre><p style="white-space: pre-wrap; word-wrap: break-word;">This way it's very clear whihc members of the master struct are related to the jitter buffer [only] and which not.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/9214">change 9214</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9214"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ie07b8a577caf731d59d68e3b3510ae2f9fd3dc93 </div>
<div style="display:none"> Gerrit-Change-Number: 9214 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Comment-Date: Sun, 20 May 2018 06:56:11 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>