<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/9208">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">tests: a5_test: Print wrong buffer correctly on error<br><br>Before this patch, osmo_hexdump is called stacked in th esame printf<br>function. As a result, the first returned buffer is overwriten by the<br>second, which means the printed buffers will show as the same always.<br><br>Change-Id: I364328a59da31537c6c9b969e34edd360b685081<br>---<br>M tests/a5/a5_test.c<br>1 file changed, 3 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/a5/a5_test.c b/tests/a5/a5_test.c</span><br><span>index 6d7cc3c..69f1035 100644</span><br><span>--- a/tests/a5/a5_test.c</span><br><span>+++ b/tests/a5/a5_test.c</span><br><span>@@ -48,7 +48,9 @@</span><br><span>     osmo_hexparse(block, res, len);</span><br><span>      osmo_ubit2pbit(buf, out, 114);</span><br><span>       if (0 != memcmp(buf, res, len)) {</span><br><span style="color: hsl(0, 100%, 40%);">-               printf("FAIL\nGOT: [%d] %s\nEXP: [%d] %s\n", k, osmo_hexdump_nospc(buf, len), k, osmo_hexdump_nospc(res, len));</span><br><span style="color: hsl(120, 100%, 40%);">+             printf("FAIL:\n");</span><br><span style="color: hsl(120, 100%, 40%);">+          printf("GOT: [%d] %s\n", k, osmo_hexdump_nospc(buf, len));</span><br><span style="color: hsl(120, 100%, 40%);">+          printf("EXP: [%d] %s\n", k, osmo_hexdump_nospc(res, len));</span><br><span>                 return false;</span><br><span>        }</span><br><span>    printf("OK\n");</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9208">change 9208</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9208"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I364328a59da31537c6c9b969e34edd360b685081 </div>
<div style="display:none"> Gerrit-Change-Number: 9208 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>