<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/9205">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">tests: bitrev_test: Fix dynamic-stack-buffer-overflow<br><br>Fixes following AddressSanitizer report:<br>==1983==ERROR: AddressSanitizer: dynamic-stack-buffer-overflow on address 0x7ffc245f47e6 at pc 0x7f3e2deea68c bp 0x7ffc245f4750 sp 0x7ffc245f4740<br>WRITE of size 1 at 0x7ffc245f47e6 thread T0<br>    #0 0x7f3e2deea68b in osmo_nibble_shift_right libosmocore/src/bits.c:92<br>    #1 0x55c01902e1ab in sh_chk libosmocore/tests/bits/bitrev_test.c:215<br>    #2 0x55c01902ed8f in main libosmocore/tests/bits/bitrev_test.c:305<br>    #3 0x7f3e2c93006a in __libc_start_main (/usr/lib/libc.so.6+0x2306a)<br>    #4 0x55c01902c059 in _start (libosmocore/tests/bits/.libs/lt-bitrev_test+0x5059)<br><br>This patch can be seen as a follow-up of commit<br>4fd6023b0383e7efa3b7b0211104a86ff5d3d4f6, which already fixed the<br>left-shift case in the same way.<br><br>Change-Id: I6e86d0164b7e982bf7b7449d5b3abfb3e1e5da46<br>---<br>M tests/bits/bitrev_test.c<br>M tests/bits/bitrev_test.ok<br>2 files changed, 3 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/bits/bitrev_test.c b/tests/bits/bitrev_test.c</span><br><span>index ed3939a..4a3c1b4 100644</span><br><span>--- a/tests/bits/bitrev_test.c</span><br><span>+++ b/tests/bits/bitrev_test.c</span><br><span>@@ -299,10 +299,11 @@</span><br><span>         for (offs = 0; offs < 13; offs++) {</span><br><span>               sh_chk(in1, ARRAY_SIZE(in1), offs, true);</span><br><span>            sh_chk(in1, ARRAY_SIZE(in1), offs, false);</span><br><span style="color: hsl(0, 100%, 40%);">-              sh_chk(in2, ARRAY_SIZE(in2), offs, true);</span><br><span>            /* in2 is too short to shift left 12 nibbles */</span><br><span style="color: hsl(0, 100%, 40%);">-         if (offs < 12)</span><br><span style="color: hsl(120, 100%, 40%);">+             if (offs < 12) {</span><br><span style="color: hsl(120, 100%, 40%);">+                   sh_chk(in2, ARRAY_SIZE(in2), offs, true);</span><br><span>                    sh_chk(in2, ARRAY_SIZE(in2), offs, false);</span><br><span style="color: hsl(120, 100%, 40%);">+            }</span><br><span>    }</span><br><span>    return 0;</span><br><span> }</span><br><span>diff --git a/tests/bits/bitrev_test.ok b/tests/bits/bitrev_test.ok</span><br><span>index d2fb12c..580fb63 100644</span><br><span>--- a/tests/bits/bitrev_test.ok</span><br><span>+++ b/tests/bits/bitrev_test.ok</span><br><span>@@ -154,5 +154,3 @@</span><br><span>      OUT: 0f00dcafedea</span><br><span> [8] L IN: f00dcafedeadbeef, nibble 12:</span><br><span>      OUT: 00dcafedeadb</span><br><span style="color: hsl(0, 100%, 40%);">-[6] R IN: b00bbabeface, nibble 12:</span><br><span style="color: hsl(0, 100%, 40%);">-     OUT: 0b00bbabefac</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9205">change 9205</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9205"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I6e86d0164b7e982bf7b7449d5b3abfb3e1e5da46 </div>
<div style="display:none"> Gerrit-Change-Number: 9205 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>