<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/9165">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Don't register SIGHUP handler without actually handling SIGHUP<br><br>In libosmocore, we normally register a SIGHUP handler for log file<br>rotation.<br><br>However, the osmo-pcu code so far installed its own signal handler,<br>which did exactly nothing in the SIGHUP case.<br><br>Let's fix this by removing SIGHUP handling here, letting libosmocore<br>take care about this.<br><br>Change-Id: Ifa20d79770bc4d88d40601b008a3a2a79d083c04<br>Closes: OS#3265<br>---<br>M src/pcu_main.cpp<br>1 file changed, 2 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/pcu_main.cpp b/src/pcu_main.cpp</span><br><span>index 5b1b1be..7480842 100644</span><br><span>--- a/src/pcu_main.cpp</span><br><span>+++ b/src/pcu_main.cpp</span><br><span>@@ -143,7 +143,7 @@</span><br><span> </span><br><span> void sighandler(int sigset)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-     if (sigset == SIGHUP || sigset == SIGPIPE)</span><br><span style="color: hsl(120, 100%, 40%);">+    if (sigset == SIGPIPE)</span><br><span>               return;</span><br><span> </span><br><span>  fprintf(stderr, "Signal %d received.\n", sigset);</span><br><span>@@ -155,7 +155,6 @@</span><br><span>             * is terminated without finishing shutdown process.</span><br><span>                  */</span><br><span>          signal(SIGINT, SIG_DFL);</span><br><span style="color: hsl(0, 100%, 40%);">-                signal(SIGHUP, SIG_DFL);</span><br><span>             signal(SIGTERM, SIG_DFL);</span><br><span>            signal(SIGPIPE, SIG_DFL);</span><br><span>            signal(SIGABRT, SIG_DFL);</span><br><span>@@ -311,12 +310,12 @@</span><br><span>            return rc;</span><br><span> </span><br><span>       signal(SIGINT, sighandler);</span><br><span style="color: hsl(0, 100%, 40%);">-     signal(SIGHUP, sighandler);</span><br><span>  signal(SIGTERM, sighandler);</span><br><span>         signal(SIGPIPE, sighandler);</span><br><span>         signal(SIGABRT, sighandler);</span><br><span>         signal(SIGUSR1, sighandler);</span><br><span>         signal(SIGUSR2, sighandler);</span><br><span style="color: hsl(120, 100%, 40%);">+  osmo_init_ignore_signals();</span><br><span> </span><br><span>      /* enable realtime priority for us */</span><br><span>        if (rt_prio != -1) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9165">change 9165</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9165"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ifa20d79770bc4d88d40601b008a3a2a79d083c04 </div>
<div style="display:none"> Gerrit-Change-Number: 9165 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>