<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/8065">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">free msgb for primitive allocated in lm_timer_cb() of lm_fsm<br><br>A primitive allocated in lm_timer_cb() with xua_xlm_prim_alloc()<br>was never freed. Don't forget to free the msgb in osmo_xlm_sap_down().<br><br>Found by code inspection.<br><br>Also, assert that allocation suceeded like we do elsewhere.<br><br>Change-Id: Ie667b1b8beeda2aa4520a1413f51101435215cc0<br>Related: OS#2449<br>---<br>M src/xua_default_lm_fsm.c<br>M src/xua_rkm.c<br>2 files changed, 2 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/xua_default_lm_fsm.c b/src/xua_default_lm_fsm.c</span><br><span>index eba89c2..11a97a2 100644</span><br><span>--- a/src/xua_default_lm_fsm.c</span><br><span>+++ b/src/xua_default_lm_fsm.c</span><br><span>@@ -175,6 +175,7 @@</span><br><span>            * let's dynamically register */</span><br><span>                 osmo_fsm_inst_state_chg(fi, S_RKM_REG, 10, T_WAIT_RK_REG_RESP);</span><br><span>              prim = xua_xlm_prim_alloc(OSMO_XLM_PRIM_M_RK_REG, PRIM_OP_REQUEST);</span><br><span style="color: hsl(120, 100%, 40%);">+           OSMO_ASSERT(prim);</span><br><span>           as = find_first_as_in_asp(lmp->asp);</span><br><span>              if (!as) {</span><br><span>                   LOGPFSML(fi, LOGL_ERROR, "Unable to find AS!\n");</span><br><span>diff --git a/src/xua_rkm.c b/src/xua_rkm.c</span><br><span>index b3c5be7..b79f7f3 100644</span><br><span>--- a/src/xua_rkm.c</span><br><span>+++ b/src/xua_rkm.c</span><br><span>@@ -545,6 +545,7 @@</span><br><span>           break;</span><br><span>       }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ msgb_free(prim->oph.msg);</span><br><span>         return 0;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/8065">change 8065</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/8065"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-sccp </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ie667b1b8beeda2aa4520a1413f51101435215cc0 </div>
<div style="display:none"> Gerrit-Change-Number: 8065 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Stefan Sperling <ssperling@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>