Change in osmo-gbproxy[master]: gbproxy: Route BSSGP STATUS with PDU_IN_ERROR containing a TLLI

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

daniel gerrit-no-reply at lists.osmocom.org
Thu Sep 30 08:55:47 UTC 2021


daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/25077 )

Change subject: gbproxy: Route BSSGP STATUS with PDU_IN_ERROR containing a TLLI
......................................................................


Patch Set 4:

(2 comments)

> Patch Set 4:
> 
> (2 comments)
> 
> LGTM besides cosmetics

Thanks, I also found/fixed some inconsistencies with tp/tp_inner usage (also affects the other patch)

https://gerrit.osmocom.org/c/osmo-gbproxy/+/25077/4/src/gb_proxy.c 
File src/gb_proxy.c:

https://gerrit.osmocom.org/c/osmo-gbproxy/+/25077/4/src/gb_proxy.c@1000 
PS4, Line 1000: "FOO"
> prefix for log messages: FOO? :)  […]
Done


https://gerrit.osmocom.org/c/osmo-gbproxy/+/25077/4/src/gb_proxy.c@1130 
PS4, Line 1130: 		 * if we can extract a TLLI/RNI to route it to the correct SGSN */
> looks like the fixme is now implemented?
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/25077
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gbproxy
Gerrit-Branch: master
Gerrit-Change-Id: I9d2ec73520ee46ceedda3f7e63035e6a51a65ac2
Gerrit-Change-Number: 25077
Gerrit-PatchSet: 4
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 30 Sep 2021 08:55:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210930/24c68e7f/attachment.htm>


More information about the gerrit-log mailing list