This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
osmith gerrit-no-reply at lists.osmocom.orgosmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/25484 )
Change subject: pySim-shell: refactor __main__ section
......................................................................
Patch Set 7:
(3 comments)
besides cosmetics, LGTM
https://gerrit.osmocom.org/c/pysim/+/25484/2/pySim-shell.py
File pySim-shell.py:
https://gerrit.osmocom.org/c/pysim/+/25484/2/pySim-shell.py@66
PS2, Line 66: print("No card detected!")
> I wonder if changing this makes the use of this function easier. […]
(I would lean towards using proper exceptions, but then again I haven't used pysim-shell yet, just reviewing patches. so if you say this makes more sense then fine with me.)
https://gerrit.osmocom.org/c/pysim/+/25484/7/pySim-shell.py
File pySim-shell.py:
https://gerrit.osmocom.org/c/pysim/+/25484/7/pySim-shell.py@64
PS7, Line 64: ;
; is not needed at the end of commands in python, same below
https://gerrit.osmocom.org/c/pysim/+/25484/7/pySim-shell.py@529
PS7, Line 529: if (sl is None)
() around conditions not needed
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/25484
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Id2a0f2012b84ce61f5c0c14404df559fca4ddfcd
Gerrit-Change-Number: 25484
Gerrit-PatchSet: 7
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Wed, 29 Sep 2021 14:24:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Comment-In-Reply-To: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210929/e781f1d0/attachment.htm>