Change in osmo-bts[master]: bts-trx: Submit TRX_PROV_EV_CFG_ARFCN for C0 during SetBtsAttr

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Sep 23 09:11:57 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25525 )

Change subject: bts-trx: Submit TRX_PROV_EV_CFG_ARFCN for C0 during SetBtsAttr
......................................................................


Patch Set 3:

> Patch Set 3:
> 
> Would be also good to know what's wrong with the current implementation and what do we benefit from this patch? Right now, while doing code review, it feels like some upcoming patches require this.

Well, the previous way it was done was plainly wrong, because event for ARFCN ready was sent at a time when the ARFCN was retreived. It just happened to work before because in general we would get SetBtsAttr before IPA SetRadioAttributes. So regardless of changes done after it, this patch is correct on its own.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25525
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I8aa9652622107fe0a707b2cbcbe8be6c71e19087
Gerrit-Change-Number: 25525
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Thu, 23 Sep 2021 09:11:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210923/4bea1377/attachment.htm>


More information about the gerrit-log mailing list