Change in libosmo-abis[master]: e1_input: Fix line not removed from e1inp_line_list when freed

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Sep 23 08:23:27 UTC 2021


pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/25545 )

Change subject: e1_input: Fix line not removed from e1inp_line_list when freed
......................................................................

e1_input: Fix line not removed from e1inp_line_list when freed

This was not an observable issue so far because both osmo-bts and
osmo-bsc used to keep the same line created once, keeping at least 1
reference count to it.

Change-Id: I1314d6b917ecb622994507475eb894e649a1a2ad
---
M src/e1_input.c
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  osmith: Looks good to me, approved



diff --git a/src/e1_input.c b/src/e1_input.c
index 93ab446..fd3082e 100644
--- a/src/e1_input.c
+++ b/src/e1_input.c
@@ -452,6 +452,8 @@
 		if (line->driver_data)
 			talloc_unlink(line, line->driver_data);
 	}
+
+	llist_del(&line->list);
 	talloc_free(line);
 	return 0;
 }

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/25545
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I1314d6b917ecb622994507475eb894e649a1a2ad
Gerrit-Change-Number: 25545
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210923/9042a4e2/attachment.htm>


More information about the gerrit-log mailing list