This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25519 ) Change subject: trx_provision_fsm: Properly reset FSM state upon starting listening for events ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/25519/2/src/osmo-bts-trx/trx_provision_fsm.c File src/osmo-bts-trx/trx_provision_fsm.c: https://gerrit.osmocom.org/c/osmo-bts/+/25519/2/src/osmo-bts-trx/trx_provision_fsm.c@100 PS2, Line 100: > looks like a memset to zero? Kind of but not for all fields in struct, hence I manually set them to zero. Some fields must not be zeroed here, like forced_max_power_red or nominal_power_set_by_vty. I could rearrange all these fields into its own substructs and memzero them, but that would require touching different parts of code and as you can see I'm already queueing quite a lot of changes in the entire patchset. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25519 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If0d078bc0170091efbca351c44ee412dad1e944a Gerrit-Change-Number: 25519 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Wed, 22 Sep 2021 11:00:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge at osmocom.org> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210922/22fd18e5/attachment.htm>