Change in osmo-trx[master]: lms,uhd: Skip re-assigning same band

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed Sep 22 10:50:57 UTC 2021


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/25523 )

Change subject: lms,uhd: Skip re-assigning same band
......................................................................

lms,uhd: Skip re-assigning same band

There's no need to spend time looking up again the same band
description.

Change-Id: I6f5631c9e64b9c261d52a856d757d08d2f336947
---
M Transceiver52M/device/lms/LMSDevice.cpp
M Transceiver52M/device/uhd/UHDDevice.cpp
2 files changed, 8 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  osmith: Looks good to me, but someone else must approve



diff --git a/Transceiver52M/device/lms/LMSDevice.cpp b/Transceiver52M/device/lms/LMSDevice.cpp
index 221d7e2..95bc41e 100644
--- a/Transceiver52M/device/lms/LMSDevice.cpp
+++ b/Transceiver52M/device/lms/LMSDevice.cpp
@@ -246,8 +246,10 @@
 		return false;
 	}
 
-	band = req_band;
-	assign_band_desc(band);
+	if (band == 0) {
+		band = req_band;
+		assign_band_desc(band);
+	}
 	return true;
 }
 
diff --git a/Transceiver52M/device/uhd/UHDDevice.cpp b/Transceiver52M/device/uhd/UHDDevice.cpp
index 7a8eb9b..bc39a6d 100644
--- a/Transceiver52M/device/uhd/UHDDevice.cpp
+++ b/Transceiver52M/device/uhd/UHDDevice.cpp
@@ -264,8 +264,10 @@
 		return false;
 	}
 
-	band = req_band;
-	assign_band_desc(band);
+	if (band == 0) {
+		band = req_band;
+		assign_band_desc(band);
+	}
 	return true;
 }
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/25523
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I6f5631c9e64b9c261d52a856d757d08d2f336947
Gerrit-Change-Number: 25523
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210922/1b66438c/attachment.htm>


More information about the gerrit-log mailing list