This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25464 ) Change subject: refactor stat_item: get rid of FIFO and "skipped" error ...................................................................... Patch Set 3: It makes no practical sense to keep the struct members. I cannot possibly know that all users out there in the world aren't accessing those members directly. That's why we have a policy to not do API breakage at all. And still, if anyone accesses those members, they will no longer get their intended results. So this is a dilemma of sorts. To me it seems accepting this API breakage is the best way. The *actual* cleanest way would be to abandon osmo_stat_item and implement osmo_stat_item2 instead. Then move all of our programs to osmo_stat_item2; and keep osmo_stat_item as idle cruft forever. That seems considerable effort that isn't needed when accepting the API breakage. But maybe the effort isn't that bad after all? One patch s/osmo_stat_item\>/osmo_stat_item2/g per git.osmocom.org repos? @laforge, what do you think? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25464 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I137992a5479fc39bbceb6c6c2af9c227bd33b39b Gerrit-Change-Number: 25464 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-CC: osmith <osmith at sysmocom.de> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 20 Sep 2021 13:13:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210920/c19b296d/attachment.htm>