This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25507 ) Change subject: stat: add bts.N.num_trx:rsl_connected ...................................................................... stat: add bts.N.num_trx:rsl_connected Controversy: this duplicates bts.N.rsl_connected. I would like to add this duplication for consistency, since we now have these counters: bsc.0.num_trx:rsl_connected bsc.0.num_trx:total bts.N.num_trx:total and the old bts.N.rsl_connected which does not fit well with above naming scheme. Any user will be justified to expect a stat named bts.N.num_trx:rsl_connected as well. Determine bts.N.num_trx:rsl_connected in the new function bsc_update_connection_stats(), where the other num_trx:* are set. Related: SYS#5542 Related: I5be1cb470930354c4561cbed301bc50a32484ed9 (osmo-ttcn3-hacks) Change-Id: I55b55159fe13d937e441d8c2ed915734463e1154 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/bsc_stats.c M src/osmo-bsc/bts.c 3 files changed, 8 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/07/25507/1 diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h index f09d068..68654f2 100644 --- a/include/osmocom/bsc/bts.h +++ b/include/osmocom/bsc/bts.h @@ -175,6 +175,7 @@ BTS_STAT_RSL_CONNECTED, BTS_STAT_LCHAN_BORKEN, BTS_STAT_TS_BORKEN, + BTS_STAT_NUM_TRX_RSL_CONNECTED, BTS_STAT_NUM_TRX_TOTAL, }; diff --git a/src/osmo-bsc/bsc_stats.c b/src/osmo-bsc/bsc_stats.c index 3b96fed..7176809 100644 --- a/src/osmo-bsc/bsc_stats.c +++ b/src/osmo-bsc/bsc_stats.c @@ -162,6 +162,8 @@ trx_rsl_connected++; } + osmo_stat_item_set(osmo_stat_item_group_get_item(bts->bts_statg, BTS_STAT_NUM_TRX_RSL_CONNECTED), + trx_rsl_connected); osmo_stat_item_set(osmo_stat_item_group_get_item(bts->bts_statg, BTS_STAT_NUM_TRX_TOTAL), num_trx); diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index 86fa823..1b80ef6 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -1303,7 +1303,7 @@ "", 16, 0 }, [BTS_STAT_RSL_CONNECTED] = \ { "rsl_connected", - "Number of RSL links connected", + "Number of RSL links connected (same as num_trx:rsl_connected)", "", 16, 0 }, [BTS_STAT_LCHAN_BORKEN] = \ { "lchan_borken", @@ -1313,6 +1313,10 @@ { "ts_borken", "Number of timeslots in the BORKEN state", "", 16, 0 }, + [BTS_STAT_NUM_TRX_RSL_CONNECTED] = + { "num_trx:rsl_connected", + "Number of TRX in this BTS where RSL is up", + "" }, [BTS_STAT_NUM_TRX_TOTAL] = { "num_trx:total", "Number of configured TRX in this BTS", -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25507 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I55b55159fe13d937e441d8c2ed915734463e1154 Gerrit-Change-Number: 25507 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210919/1a129dc3/attachment.htm>