This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25503 ) Change subject: MS Power Control Loop: Fix oscillations within good MS Power Levels ...................................................................... Patch Set 1: Code-Review-1 (4 comments) https://gerrit.osmocom.org/c/osmo-bts/+/25503/1/tests/power/ms_power_loop_test.err File tests/power/ms_power_loop_test.err: https://gerrit.osmocom.org/c/osmo-bts/+/25503/1/tests/power/ms_power_loop_test.err@61 PS1, Line 61: Ignoring MS power control level 10 (10 dBm) => 9 (12 dBm): I find this logging message confusing: how can you ignore "MS power control level"? If we do not change the power level, then let's not print anything at all? https://gerrit.osmocom.org/c/osmo-bts/+/25503/1/tests/power/ms_power_loop_test.err@62 PS1, Line 62: Keeping MS power at control level 10 ... or print this message instead? https://gerrit.osmocom.org/c/osmo-bts/+/25503/1/tests/power/ms_power_loop_test.ok File tests/power/ms_power_loop_test.ok: https://gerrit.osmocom.org/c/osmo-bts/+/25503/1/tests/power/ms_power_loop_test.ok@169 PS1, Line 169: 0 (expected 1) 0 vs 1 https://gerrit.osmocom.org/c/osmo-bts/+/25503/1/tests/power/ms_power_loop_test.ok@178 PS1, Line 178: 9 -> 10 Do we really expect any changes of the power level? AFAIU from the commit message, it's expected to remain constant, but here I can see it changes... -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25503 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib33a94eba92004f9327c91e020a506dfa9a957c3 Gerrit-Change-Number: 25503 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Comment-Date: Sat, 18 Sep 2021 17:34:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210918/cfadc136/attachment.htm>