This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/25499 ) Change subject: pySim-prog: rename card_handler to CardHandler ...................................................................... Patch Set 5: > Patch Set 3: > > I would have assumed it's the more logical approach to rename the local variables rather than the class. However, if the class is renamed to uppercase (which is generally a good idea) I would suggest to go for CamelCase altogether, like CardHandler. That's how all the later shell related code does it, AFAICT. I did not rename the local variables for consistency reasons. Here is a patch that follows the approach to rename the variables: https://gerrit.osmocom.org/c/pysim/+/25501 In the end I am not sure what makes more sense. Both patches do fix the problem. I personally would prefer to rename the class to "CardHandler". -- To view, visit https://gerrit.osmocom.org/c/pysim/+/25499 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4b2c06b1c607c993c9aaf0d57ad2352bb6b36e74 Gerrit-Change-Number: 25499 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 17 Sep 2021 15:24:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210917/cdfb71f2/attachment.htm>