Change in pysim[master]: pySim-prog: rename card_handler to Card_handler

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Sep 17 11:28:50 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/25499 )

Change subject: pySim-prog: rename card_handler to Card_handler
......................................................................


Patch Set 3:

I would have assumed it's the more logical approach to rename the local variables rather than the class.  However, if the class is renamed to uppercase (which is generally a good idea) I would suggest to go for CamelCase altogether, like CardHandler. That's how all the later shell related code does it, AFAICT.


-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/25499
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I4b2c06b1c607c993c9aaf0d57ad2352bb6b36e74
Gerrit-Change-Number: 25499
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Fri, 17 Sep 2021 11:28:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210917/0dc91684/attachment.htm>


More information about the gerrit-log mailing list