This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25400 ) Change subject: Add stats: pcu.bts.N.pdch.occupied.gprs/egprs ...................................................................... Patch Set 3: (2 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/25400/3/src/pdch.cpp File src/pdch.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/25400/3/src/pdch.cpp@1041 PS3, Line 1041: enum tbf_type type = tbf->is_egprs_enabled() ? TBF_TYPE_EGPRS : TBF_TYPE_GPRS; you can simply change this to: uint8_t is_egprs = tbf->is_egprs_enabled() ? 1 : 0; ... m_num_tbfs[tbf->direction][is_egprs] += inc; https://gerrit.osmocom.org/c/osmo-pcu/+/25400/3/src/tbf.h File src/tbf.h: https://gerrit.osmocom.org/c/osmo-pcu/+/25400/3/src/tbf.h@89 PS3, Line 89: enum tbf_type { I would really avoid having an enum for 2 different options, which can be easily simplified to "is_egprs". I'd like to avoid having this enum only for the sake of accessing one array of 2 items, which could even be split into 2 variables if you feel it looks better to you. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25400 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I0c0a1121b4ae5f031782e7e63a0c28eb0b6c8b42 Gerrit-Change-Number: 25400 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 17 Sep 2021 10:20:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210917/d8a43987/attachment.htm>