This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25464 ) Change subject: refactor stat_item: get rid of FIFO and "skipped" error ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/c/libosmocore/+/25464/2/include/osmocom/core/stat_item.h File include/osmocom/core/stat_item.h: https://gerrit.osmocom.org/c/libosmocore/+/25464/2/include/osmocom/core/stat_item.h@46 PS2, Line 46: struct osmo_stat_item_value values[0]; It really makes no sense to keep this, since anyway it points to a now wrong memory region not containing the expected values? Or is it always 0 from last_offs? https://gerrit.osmocom.org/c/libosmocore/+/25464/1/include/osmocom/core/stat_item.h File include/osmocom/core/stat_item.h: https://gerrit.osmocom.org/c/libosmocore/+/25464/1/include/osmocom/core/stat_item.h@42 PS1, Line 42: int32_t not_stats_next_id; > oh whoops i didn't mean to rename the member at all. […] So I assume from your tests that these fields are not being used directl by anybody anymore? If that's the case, I'd favor dropping them. Specially since it's a few bytes per item, where a group instance can have a lot of items and a program can have a lot of group instances. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25464 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I137992a5479fc39bbceb6c6c2af9c227bd33b39b Gerrit-Change-Number: 25464 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 16 Sep 2021 10:58:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de> Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210916/1dfffa87/attachment.htm>