Change in osmo-bts[master]: power_control: Drop unused param in function

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed Sep 15 17:12:35 UTC 2021


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/25475 )


Change subject: power_control: Drop unused param in function
......................................................................

power_control: Drop unused param in function

Change-Id: I6c0c2b983e153b06b84664565bd485e748a8af7d
---
M src/common/power_control.c
1 file changed, 3 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/75/25475/1

diff --git a/src/common/power_control.c b/src/common/power_control.c
index d57c28d..bcea073 100644
--- a/src/common/power_control.c
+++ b/src/common/power_control.c
@@ -111,10 +111,9 @@
 	}
 	return val_avg;
 }
-/* Calculate a 'delta' value (for the given MS/BS power control state and parameters)
+/* Calculate a 'delta' value (for the given MS/BS power control parameters)
  * to be applied to the current Tx power level to approach the target level. */
 static int calc_delta_rxlev(const struct gsm_power_ctrl_params *params,
-		      struct lchan_power_ctrl_state *state,
 		      const uint8_t rxlev)
 {
 	int delta;
@@ -236,7 +235,7 @@
 		new_dbm = ms_dbm - params->red_step_size_db;
 	} else {
 		/* Calculate the new Tx power value (in dBm) */
-		new_dbm = ms_dbm + calc_delta_rxlev(params, state, rxlev_avg);
+		new_dbm = ms_dbm + calc_delta_rxlev(params, rxlev_avg);
 	}
 
 	/* Make sure new_dbm is never negative. ms_pwr_ctl_lvl() can later on
@@ -364,7 +363,7 @@
 		 *   RxLev + Delta = TxPwr - PathLoss -  TxAtt + Delta
 		 *   RxLev + Delta = TxPwr - PathLoss - (TxAtt - Delta)
 		 */
-		new_att = state->current - calc_delta_rxlev(params, state, rxlev_avg);
+		new_att = state->current - calc_delta_rxlev(params, rxlev_avg);
 	}
 
 	/* Make sure new TxAtt is never negative: */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25475
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I6c0c2b983e153b06b84664565bd485e748a8af7d
Gerrit-Change-Number: 25475
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210915/f732cab8/attachment.htm>


More information about the gerrit-log mailing list