Change in osmo-bts[master]: scheduler: Apply BCCH Carrier Power Reduction attenuation to PDCH TS ...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed Sep 15 16:40:48 UTC 2021


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/25474 )


Change subject: scheduler: Apply BCCH Carrier Power Reduction attenuation to PDCH TS on C0
......................................................................

scheduler: Apply BCCH Carrier Power Reduction attenuation to PDCH TS on C0

The commit implementing BCCH Carrier Power Reduction forgot to apply it
for bursts for which there's no lchan controlled by OsmoBTS, such as
those coming from PDCH timeslots.

For other TRX, BS Power Reduction is still always 0. The BS Power Control
Loop for those channels still needs to be implemented in OsmoPCU and the
resulting bs_powerbe passed somehow over PCUIF together with RLCMAC data
to OsmoBTS, so it can be applied there.

Fixes: 0e8d68437af4a99dc99d11d4e1f441246bd3ec00
Related: SYS#4919
Change-Id: I3c6985c2bc6779b15094a34f5d4a345c7d8d7b38
---
M src/common/scheduler.c
1 file changed, 5 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/74/25474/1

diff --git a/src/common/scheduler.c b/src/common/scheduler.c
index 6e1e4fb..e7eac96 100644
--- a/src/common/scheduler.c
+++ b/src/common/scheduler.c
@@ -1318,7 +1318,11 @@
 	/* BS Power reduction (in dB) per logical channel */
 	if (l1cs->lchan != NULL)
 		br->att = l1cs->lchan->bs_power_ctrl.current;
-	else /* Ensure no attenuation in the absence of lchan (e.g. on PDCH) */
+	/* Ensure no/reduced attenuation in the absence of lchan (e.g. on PDCH).
+	 * Use calculated value for TS on TRX0 as per BCCH Carrier Power Reduction: */
+	else if (l1ts->ts->trx == l1ts->ts->trx->bts->c0)
+		br->att = l1ts->ts->c0_power_red_db;
+	else
 		br->att = 0;
 
 	/* encrypt */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25474
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I3c6985c2bc6779b15094a34f5d4a345c7d8d7b38
Gerrit-Change-Number: 25474
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210915/f9b215a0/attachment.htm>


More information about the gerrit-log mailing list