Change in osmo-mgw[master]: rename strip_epname and find_specific_endpoint and make them available

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Wed Sep 15 09:27:16 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25429 )

Change subject: rename strip_epname and find_specific_endpoint and make them available
......................................................................


Patch Set 17: Code-Review+1

(1 comment)

Thanks for putting the API doc. Please do not forget the dot ;-)

https://gerrit.osmocom.org/c/osmo-mgw/+/25429/17/src/libosmo-mgcp/mgcp_endp.c 
File src/libosmo-mgcp/mgcp_endp.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/25429/17/src/libosmo-mgcp/mgcp_endp.c@228 
PS17, Line 228:  *  \param[in] trunk mgcp_trunk that might have this endpoint
Looks good, but each line must end with a dot. I am not an expert in that and I also never look at the generated documentation but when the dot is missing there seems to be a huge problem.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25429
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I4f76676640a308ab84da3848e1c1ec22bd5d9566
Gerrit-Change-Number: 25429
Gerrit-PatchSet: 17
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 15 Sep 2021 09:27:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210915/b06a268d/attachment.htm>


More information about the gerrit-log mailing list