Change in osmo-bts[master]: abis.c: Convert early return to assert()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue Sep 14 13:42:15 UTC 2021


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/25455 )


Change subject: abis.c: Convert early return to assert()
......................................................................

abis.c: Convert early return to assert()

This should simply not happen. If other event is received, something is
terribly wrong, so we should exit immediately instead of silently
failing.

Change-Id: I5f4953be735f526bb8b926979233b3c26ba67ce9
---
M src/common/abis.c
1 file changed, 1 insertion(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/55/25455/1

diff --git a/src/common/abis.c b/src/common/abis.c
index db0a648..d739b3a 100644
--- a/src/common/abis.c
+++ b/src/common/abis.c
@@ -201,8 +201,7 @@
 	struct abis_link_fsm_priv *priv = fi->priv;
 	struct gsm_bts *bts = priv->bts;
 
-	if (event != ABIS_LINK_EV_VTY_RM_ADDR)
-		return;
+	OSMO_ASSERT(event == ABIS_LINK_EV_VTY_RM_ADDR);
 
 	if (priv->bsc_oml_host == data) {
 		if (llist_count(&bts->bsc_oml_hosts) <= 1)

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25455
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I5f4953be735f526bb8b926979233b3c26ba67ce9
Gerrit-Change-Number: 25455
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210914/cb0848bd/attachment.htm>


More information about the gerrit-log mailing list