Change in osmo-msc[master]: msc_vlr_test: remove DLMGCP log messages from unit test output

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Tue Sep 14 10:11:26 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/25449 )

Change subject: msc_vlr_test: remove DLMGCP log messages from unit test output
......................................................................


Patch Set 2:

> Patch Set 1: Code-Review-1
> 
> I think we shouldn't store logging from library here. Tests checking library output should be done in library itself. Let's better disable the category completely in these tests. Then osmo-msc unit tests from master work with both new and older releases of the lib just fine.

Sounds reasonable. This testsuite does not focus on MGCP anyway, so yes, disabling the output makes sense.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/25449
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Id197e4ab9ba12e284299ef520edee9c362513bf1
Gerrit-Change-Number: 25449
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 14 Sep 2021 10:11:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210914/5acc3abb/attachment.htm>


More information about the gerrit-log mailing list