Change in osmo-mgw[master]: libosmo-mgcp: atomic rate counter group indexes

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Hoernchen gerrit-no-reply at lists.osmocom.org
Mon Sep 13 14:53:26 UTC 2021


Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25422 )

Change subject: libosmo-mgcp: atomic rate counter group indexes
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.osmocom.org/c/osmo-mgw/+/25422/6//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-mgw/+/25422/6//COMMIT_MSG@11 
PS6, Line 11: 
> It may be obvious but at least I do not understand why the rate counter indexes must be atomic. […]
This was just a straightforward port of static in single threaded case to still static in a multithreaded case where multiple threads will now concurrently modify the same variables, so they need to be atomic to ensure that they are increased as expected and one thread does not just increment some old value because another one already incremented it between loading and storing the value.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25422
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ib82d15aab2b3ba25827f9cf8751dbf87ee92a444
Gerrit-Change-Number: 25422
Gerrit-PatchSet: 6
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 13 Sep 2021 14:53:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210913/ce605e02/attachment.htm>


More information about the gerrit-log mailing list