Change in osmo-mgw[master]: libosmo-mgcp: cleanup audio codex alloc

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Hoernchen gerrit-no-reply at lists.osmocom.org
Mon Sep 13 14:35:48 UTC 2021


Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25421 )

Change subject: libosmo-mgcp: cleanup audio codex alloc
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.osmocom.org/c/osmo-mgw/+/25421/6/include/osmocom/mgcp/mgcp_network.h 
File include/osmocom/mgcp/mgcp_network.h:

https://gerrit.osmocom.org/c/osmo-mgw/+/25421/6/include/osmocom/mgcp/mgcp_network.h@85 
PS6, Line 85: 	char subtype_name[64];
> Maybe add a comment where in the spec the exact length of 64 is specified? I know codec names are ra […]
Nowhere - there was previously a char audio_codec[64]; variable on the stack that limited the codec string, so that is where I got that from, and the patch does not change that.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25421
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Icc41643050a5e1ca3c66f307d60b6911ba1b8032
Gerrit-Change-Number: 25421
Gerrit-PatchSet: 6
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: dexter <pmaier at sysmocom.de>
Gerrit-Comment-Date: Mon, 13 Sep 2021 14:35:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210913/37ad69e5/attachment.htm>


More information about the gerrit-log mailing list