Change in osmo-mgw[master]: endp: do not cache cfg pointer

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Mon Sep 13 08:48:45 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25428 )

Change subject: endp: do not cache cfg pointer
......................................................................


Patch Set 12: Verified+1 Code-Review+2

(1 comment)

I think this patch makes a lot of sense. I have also verified it. Looks good to me.

https://gerrit.osmocom.org/c/osmo-mgw/+/25428/12/src/libosmo-mgcp/mgcp_network.c 
File src/libosmo-mgcp/mgcp_network.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/25428/12/src/libosmo-mgcp/mgcp_network.c@1181 
PS12, Line 1181: 							    (char *)msgb_data(msg), &buflen,
indentation seems now be messed up.

Maybe having a shorter variable for endp->trunk->cfg helps.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25428
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I2456ba63598f76200d53e00223abf60bb36a49c0
Gerrit-Change-Number: 25428
Gerrit-PatchSet: 12
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 13 Sep 2021 08:48:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210913/048328ba/attachment.htm>


More information about the gerrit-log mailing list