Change in osmo-mgw[master]: libosmo-mgcp: atomic rate counter group indexes

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Fri Sep 10 11:24:41 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25422 )

Change subject: libosmo-mgcp: atomic rate counter group indexes
......................................................................


Patch Set 5: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-mgw/+/25422/5/src/libosmo-mgcp/mgcp_ratectr.c 
File src/libosmo-mgcp/mgcp_ratectr.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/25422/5/src/libosmo-mgcp/mgcp_ratectr.c@190 
PS5, Line 190: 	static atomic_uint crcx_rate_ctr_index = 0;
Am I crazy or having 1 index variable here is enough? Hence only 1 atomic inc instead of 5.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25422
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ib82d15aab2b3ba25827f9cf8751dbf87ee92a444
Gerrit-Change-Number: 25422
Gerrit-PatchSet: 5
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 10 Sep 2021 11:24:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210910/8d909e2e/attachment.htm>


More information about the gerrit-log mailing list