Change in libosmocore[master]: ratectr: make atomic

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Hoernchen gerrit-no-reply at lists.osmocom.org
Thu Sep 9 17:36:52 UTC 2021


Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25414 )

Change subject: ratectr: make atomic
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/c/libosmocore/+/25414/1/include/osmocom/core/rate_ctr.h 
File include/osmocom/core/rate_ctr.h:

https://gerrit.osmocom.org/c/libosmocore/+/25414/1/include/osmocom/core/rate_ctr.h@8 
PS1, Line 8: stdatomic
> which c standard do we minimally depend on with  this? should we check for that in autoconf?
gnu11, as set 7 months ago in configure.ac by oliver, just like libosmocore.


https://gerrit.osmocom.org/c/libosmocore/+/25414/1/src/rate_ctr.c 
File src/rate_ctr.c:

https://gerrit.osmocom.org/c/libosmocore/+/25414/1/src/rate_ctr.c@72 
PS1, Line 72: s
> so every thread gets their own set of rate counters [counter groups]. […]
They should be initialized in one thread, and only used by other threads. There is also the matter of the ratecounter cb if you really wanted to share the list among multiple threads, you probably wouldn't want one _per thread_ operating on a shared list either...
So yes, osmotrx needs fixing, if we keep it like this.


https://gerrit.osmocom.org/c/libosmocore/+/25414/1/src/rate_ctr.c@470 
PS1, Line 470: osmo_fds
> no osmo_fds here?
copypasta mistake from the other source file that is handled like this



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25414
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I117f89add4798a250b5758543f1fb3e01d974205
Gerrit-Change-Number: 25414
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 09 Sep 2021 17:36:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210909/5e5cbe5e/attachment.htm>


More information about the gerrit-log mailing list