This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25414 ) Change subject: ratectr: make atomic ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/c/libosmocore/+/25414/1/include/osmocom/core/rate_ctr.h File include/osmocom/core/rate_ctr.h: https://gerrit.osmocom.org/c/libosmocore/+/25414/1/include/osmocom/core/rate_ctr.h@8 PS1, Line 8: stdatomic which c standard do we minimally depend on with this? should we check for that in autoconf? https://gerrit.osmocom.org/c/libosmocore/+/25414/1/src/rate_ctr.c File src/rate_ctr.c: https://gerrit.osmocom.org/c/libosmocore/+/25414/1/src/rate_ctr.c@72 PS1, Line 72: s so every thread gets their own set of rate counters [counter groups]. That may be useful in the osmo-mgw case, but I'm not sure this is a generally valid assumption. What for example about osmo-trx and it's multiple threads? In that case I would assume they all want to operate one global/shared list? https://gerrit.osmocom.org/c/libosmocore/+/25414/1/src/rate_ctr.c@470 PS1, Line 470: osmo_fds no osmo_fds here? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25414 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I117f89add4798a250b5758543f1fb3e01d974205 Gerrit-Change-Number: 25414 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Thu, 09 Sep 2021 16:36:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210909/7aa6a891/attachment.htm>