Change in libosmocore[master]: ns2: fix a crash when receiving a SIZE while configured

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Mon Sep 6 15:51:49 UTC 2021


lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/25384 )


Change subject: ns2: fix a crash when receiving a SIZE while configured
......................................................................

ns2: fix a crash when receiving a SIZE while configured

The ns2_vc_force_unconfigured() needs to be protected otherwise it would free
gss->nsvc which will be used later. It further would run into another
SNS failure which is wrong too.

Change-Id: If14b9e3fcd5d139457b10d06517302168091d8d8
---
M src/gb/gprs_ns2_sns.c
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/84/25384/1

diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c
index 7619b66..0afc06e 100644
--- a/src/gb/gprs_ns2_sns.c
+++ b/src/gb/gprs_ns2_sns.c
@@ -3021,7 +3021,9 @@
 			/* keep the NSVC we need for SNS, but unconfigure it */
 			gss->sns_nsvc->sig_weight = 0;
 			gss->sns_nsvc->data_weight = 0;
+			gss->block_no_nsvc_events = true;
 			ns2_vc_force_unconfigured(gss->sns_nsvc);
+			gss->block_no_nsvc_events = false;
 			ns2_sns_compute_local_ep_from_binds(fi);
 		}
 

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25384
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If14b9e3fcd5d139457b10d06517302168091d8d8
Gerrit-Change-Number: 25384
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210906/09cf6499/attachment.htm>


More information about the gerrit-log mailing list