This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25347 ) Change subject: revisit some calls of strtol(), stroul(), strtoull() ...................................................................... Patch Set 4: (2 comments) https://gerrit.osmocom.org/c/libosmocore/+/25347/4/src/gsm/gsm23236.c File src/gsm/gsm23236.c: https://gerrit.osmocom.org/c/libosmocore/+/25347/4/src/gsm/gsm23236.c@443 PS4, Line 443: if (osmo_str_to_int(&val, str, base, 0, INT16_MAX)) > we should really add uint counterparts of these APIs. i would rather avoid API creep for each and every data type, pretty much all callers are way way within signed int range. a caller still needs an int as return arg with a cast like below, but that's still better than also needing the endptr arg and failing to do validity checks properly. https://gerrit.osmocom.org/c/libosmocore/+/25347/4/src/vty/cpu_sched_vty.c File src/vty/cpu_sched_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/25347/4/src/vty/cpu_sched_vty.c@303 PS4, Line 303: if (*res_pid != val) > This looks really strange. […] that's because the range of pid_t is not well defined. I'm looking whether the cast falsifies the number value. if it does, we've surpassed pid_t range and rather bail. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25347 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0ebb06e751c28f7d1cdf328de29cd227a2449391 Gerrit-Change-Number: 25347 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 06 Sep 2021 13:17:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210906/0d6216d3/attachment.htm>