Change in osmo-bsc[master]: MS Power Control Loop: Support set up of C/I parameters for osmo-bts

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Sep 6 10:51:50 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25298 )

Change subject: MS Power Control Loop: Support set up of C/I parameters for osmo-bts
......................................................................


Patch Set 10: Code-Review+2

(1 comment)

RE-adding laforge's +1 after rebasing. +1+1=+2.

https://gerrit.osmocom.org/c/osmo-bsc/+/25298/10/src/osmo-bsc/bts_osmobts.c 
File src/osmo-bsc/bts_osmobts.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/25298/10/src/osmo-bsc/bts_osmobts.c@83 
PS10, Line 83: GSM_PWR_CTRL_MEAS_AVG_ALGO_NONE
> (this is already ruled out by the 'if ((TO)->TYPE. […]
Still good to leave it there for completeness (gcc could warn due to missing case from enum).



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25298
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I7e76ec47b323d469f777624b74b08752d1f5584f
Gerrit-Change-Number: 25298
Gerrit-PatchSet: 10
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 06 Sep 2021 10:51:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210906/184a74ee/attachment.htm>


More information about the gerrit-log mailing list