Change in libosmocore[master]: revisit some calls of strtol(), stroul(), strtoull()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Sun Sep 5 19:55:50 UTC 2021


Hello Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/libosmocore/+/25347

to look at the new patch set (#3).

Change subject: revisit some calls of strtol(), stroul(), strtoull()
......................................................................

revisit some calls of strtol(), stroul(), strtoull()

Replace some with atoi(), where the VTY has already validated correct
range of the argument.

Replace others with the new osmo_str_to_int() or osmo_str_to_int64()
functions, possibly covering more detection of invalid number strings.

Leave those strtol() callers that depend on endptr to provide the next
string token.

Related: SYS#5542
Change-Id: I0ebb06e751c28f7d1cdf328de29cd227a2449391
---
M src/ctrl/control_if.c
M src/gsm/gsm23003.c
M src/gsm/gsm23236.c
M src/vty/command.c
M src/vty/cpu_sched_vty.c
M src/vty/tdef_vty.c
M utils/osmo-aka-verify.c
7 files changed, 31 insertions(+), 73 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/47/25347/3
-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25347
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0ebb06e751c28f7d1cdf328de29cd227a2449391
Gerrit-Change-Number: 25347
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210905/6fc88857/attachment.htm>


More information about the gerrit-log mailing list