Change in libosmocore[master]: gprs_ns2: ensure the incoming NSVC is also the outgoing NSVC

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/25344 )


Change subject: gprs_ns2: ensure the incoming NSVC is also the outgoing NSVC
......................................................................

gprs_ns2: ensure the incoming NSVC is also the outgoing NSVC

Previous the SNS NSVC (the NSVC used for all SNS traffic) was never changed.
The 48.016 says the SNS NSVC should be the NSVC over which a request was received.
When receiving a SNS SIZE PDU over a different NSVC than the current SNS
NSVC the answer would be transmitted to a different port.

Change-Id: I36cd9488b8bca5cb99dae5cf50a55ee282e0557b
---
M src/gb/gprs_ns2_sns.c
1 file changed, 1 insertion(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/44/25344/1

diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c
index c1be0ab..7619b66 100644
--- a/src/gb/gprs_ns2_sns.c
+++ b/src/gb/gprs_ns2_sns.c
@@ -2326,8 +2326,7 @@
 	/* FIXME: how to resolve SNS FSM Instance by NSEI (SGSN)? */
 	fi = nse->bss_sns_fi;
 	gss = (struct ns2_sns_state *) fi->priv;
-	if (!gss->sns_nsvc)
-		gss->sns_nsvc = nsvc;
+	gss->sns_nsvc = nsvc;
 
 	LOGPFSML(fi, LOGL_DEBUG, "NSEI=%u Rx SNS PDU type %s\n", nsei,
 		 get_value_string(gprs_ns_pdu_strings, nsh->pdu_type));

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25344
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I36cd9488b8bca5cb99dae5cf50a55ee282e0557b
Gerrit-Change-Number: 25344
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210903/7fc983f2/attachment.htm>